[Security Solution] Coverage overview dashboard filter and search bar#163498
[Security Solution] Coverage overview dashboard filter and search bar#163498dplumlee merged 10 commits intoelastic:mainfrom
Conversation
dplumlee
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
| } | ||
| case 'setRuleStatusFilter': { | ||
| const { value } = action; | ||
| if (value.length === 0 || value.length === 2) { |
There was a problem hiding this comment.
@maximpn This weird hardcoded edge case with the length === 2 is caused by the api not taking both Enabled and Disabled as filters (because of the way the ternary written is structured here), even though we seem to have the other rule filter be an OR query join instead of an AND. Is this the expected action?
There was a problem hiding this comment.
As empty activity filter produces the same result as as all selected activity values it makes sense to omit the filter param in the request when all values are selected. I don't think there should be an ability to do the same thing in two ways. But you are right the API endpoint doesn't handle right requests when activity is set to ['enabled', 'disabled']. I thought to change it during milestone 2 but it makes sense to do it earlier.
maximpn
left a comment
maximpn
left a comment
There was a problem hiding this comment.
@dplumlee thank you for nice coverage overview dashboard filters implementation 👍 I played with the dashboard having 3K+ rules and it works as charm 🙌
Though I have concerns about code organization. It should conform with the other code in particular CoverageOverviewDashaboardContext should be similar to contexts added as a part of Rule Immutability/Customization epic.
banderror
added
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
| } | ||
| case 'setRuleStatusFilter': { | ||
| const { value } = action; | ||
| if (value.length === 0 || value.length === 2) { |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @dplumlee |
vitaliidm
left a comment
vitaliidm
left a comment
There was a problem hiding this comment.
Detection engine area LGTM
banderror
added
release_note:feature
7 participants
Summary
Addresses: #158246 and #158245
Adds the MVP filters and search bar to the coverage overview dashboard page
Screenshots
Checklist
Delete any items that are not applicable to this PR.
For maintainers